[BW-764] Use AuthSession for Communication #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb-jake
reviewed
Dec 3, 2024
| ): Promise<RPCResponseMessage> { | ||
| const { type, scheme } = wallet; | ||
|
|
||
| if (type === 'webBased') { |
Collaborator
There was a problem hiding this comment.
nit: can this just be web?
cb-jake
reviewed
Dec 4, 2024
packages/client/src/MWPClient.ts
Outdated
| const AVAILABLE_CHAINS_STORAGE_KEY = 'availableChains'; | ||
| const WALLET_CAPABILITIES_STORAGE_KEY = 'walletCapabilities'; | ||
| import * as Communicator from './components/communicator'; | ||
| import * as Communicator from './components/communication'; |
Collaborator
There was a problem hiding this comment.
nit, can we just import postRequestToWallet directly?
cb-jake
reviewed
Dec 4, 2024
| @@ -1,2 +1 @@ | |||
| export * from './handleResponse'; | |||
Collaborator
There was a problem hiding this comment.
Can we remove this barrel file. Not great for tree shaking
cb-jake
reviewed
Dec 4, 2024
|
|
||
| provider = new EIP1193Provider({ | ||
| metadata: { appName: 'Test App', appDeeplinkUrl: 'test://deeplink' }, | ||
| metadata: { appName: 'Test App', appCustomScheme: 'test://deeplink' }, |
Collaborator
There was a problem hiding this comment.
If we're publishing a new version do we really need the app prefix on these vars?
can we just same name, scheme, etc...? feels a tad verbose
cb-jake
reviewed
Dec 4, 2024
Comment on lines
+43
to
+44
| appName: string; | ||
| appLogoUrl?: string; |
Collaborator
There was a problem hiding this comment.
Does the scw client expect this naming still?
Collaborator
Author
There was a problem hiding this comment.
yea, scw client is expecting app prefix from both web sdk and mobile sdk, so keeping it like this for simplicity
cb-jake
reviewed
Dec 4, 2024
packages/client/src/MWPClient.ts
Outdated
| const AVAILABLE_CHAINS_STORAGE_KEY = 'availableChains'; | ||
| const WALLET_CAPABILITIES_STORAGE_KEY = 'walletCapabilities'; | ||
| import * as Communicator from './components/communicator'; | ||
| import * as Communicator from './components/communication/postRequestToWallet'; |
Collaborator
There was a problem hiding this comment.
Suggested change
| import * as Communicator from './components/communication/postRequestToWallet'; | |
| import { postRequestToWallet } from './components/communication/postRequestToWallet'; |
cb-jake
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We decided to switch over to AuthSession for many benefits including shared cookies w standalone browser, more reliable deeplinking via custom scheme, etc.
This PR:
openAuthSessionAsyncappDeeplinkUrlfromAppMetadataappCustomSchemeis now required inAppMetadatahandleResponseas this is now handled by Expo and consumer won't need to handle response URL manually1.0.0for next releaseHow did you test your changes?
Screen.Recording.2024-12-03.at.3.03.22.PM.mov
Screen.Recording.2024-12-03.at.3.14.05.PM.mov